Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28910 )
Change subject: flashchips: Add W25Q128.V..W ......................................................................
Patch Set 5:
(2 comments)
Removed all whitespace and replaced by tabs
https://review.coreboot.org/#/c/28910/2/flashchips.h File flashchips.h:
https://review.coreboot.org/#/c/28910/2/flashchips.h@928 PS2, Line 928: #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */
comment should be indented with a tab
Done
https://review.coreboot.org/#/c/28910/2/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/28910/2/flashchips.c@15671 PS2, Line 15671: .manufacture_id = WINBOND_NEX_ID,
Entries should be ordered alphabetically. So this would come after […]
Done
-
Patrick Rudolph (Code Review)