Change in flashrom[master]: dummyflasher.c: Fix use-after-free issue

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/55014 )

Change subject: dummyflasher.c: Fix use-after-free issue
......................................................................

dummyflasher.c: Fix use-after-free issue

Issue accidentally introduced in commit e3707bbf4.

BUG=none
BRANCH=none
TEST=builds

Change-Id: Ie12d6474ef5a7bb1afbbb9ec50b31b577da1a81b
Signed-off-by: Edward O'Callaghan <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55014
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: Angel Pons <[e-mail]>
Reviewed-by: Anastasia Klimchuk <[e-mail]>
---
M dummyflasher.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Anastasia Klimchuk: Looks good to me, but someone else must approve



diff --git a/dummyflasher.c b/dummyflasher.c
index b7cfab8..325263d 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -700,12 +700,13 @@
 	tmp = extract_programmer_param("spi_write_256_chunksize");
 	if (tmp) {
 		data->spi_write_256_chunksize = strtoul(tmp, &endptr, 0);
-		free(tmp);
 		if (*endptr != '\0' || data->spi_write_256_chunksize < 1) {
 			msg_perr("invalid spi_write_256_chunksize\n");
+			free(tmp);
 			return 1;
 		}
 	}
+	free(tmp);
 
 	tmp = extract_programmer_param("spi_blacklist");
 	if (tmp) {

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie12d6474ef5a7bb1afbbb9ec50b31b577da1a81b
Gerrit-Change-Number: 55014
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged