Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58735 )
Change subject: ichspi: Split very long init function into two ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58735/comment/3c599105_133c98b5 PS3, Line 20: TEST=1) probe-read-verify-erase section-write-reboot : on Intel octopus board with GD25LQ128C/GD25LQ128D/GD25LQ128E : 2) probe and read on Panther Point (7 series PCH)
Did I do the right by adding test info into commit message? Do I need to added Tested-By tags? I don […]
Personally, I don't really like these "tags" (here TEST or in other commits sometimes TESTED), because this way you are not able to write multiple lines which still fit to the style of the rest of the commit message. So, what people do is, they write half broken sentences (to shorten the characters count) and sometimes I have no idea what they are trying to tell me or what the meaning is.
However, I would only use tags if the text behind it fits in the same line. Otherwise, like in your case, I would write it as follow and I would move it before that BUG tag, to make it part of the "actual" commit summary (since I think it is relevant information):
Tests done: 1) Probe-read-verify-erase section-write-reboot on Intel octopus board with GD25LQ128C/GD25LQ128D/GD25LQ128E 2) Probe and read on Panther Point (7 series PCH)
Of course you can add a Tested-by tag for another person. Even if it is not you, it adds useful information for the readers, since they are able to contact these persons then. There might be cases, where there are multiple ways to test things. Everyone might use a different way and each one might give another experience (not only in knowledge, but also in usability and meaningfulness). So this is definitely useful :)
-
Felix Singer (Code Review)