Attention is currently required from: Nico Huber, Michał Żygowski, Jonathan Zhang, David Hendricks. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets ......................................................................
Patch Set 4:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/7418daad_5d531977 PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
"Unknown flash descriptor, assuming 300 series compatibility" and "Peculiar flash descriptor, assumi […]
AIUI, the message in this path says "Unknown" because it's the path where none of the evaluated conditions is true. In the "Peculiar" paths, we know more about the flash descriptor because at least one check is true.
If one were to remove all instances of `else` in this function (while preserving behavior, of course), the "Unknown" message would be at the end of the function, whereas the "Peculiar" messages would all be inside an if-block. Hmmm, I like the refactoring idea.
-
Angel Pons (Code Review)