Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email )
Change subject: libflashrom: Update the API for Logger Callback
......................................................................
Patch Set 7:
(2 comments)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86875/comment/93e4c07f_b8ed4089?usp... :
PS7, Line 75: (unsigned)size+1
in here, you need spaces between +, […]
Done
https://review.coreboot.org/c/flashrom/+/86875/comment/c4b7e52a_8e48b5cc?usp... :
PS7, Line 75: if (((unsigned)size+1) > sizeof(message))
: return -ERANGE;
Thank you so much for writing in that much details, this is helpful! I read everything and did lots […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86875?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Gerrit-Change-Number: 86875
Gerrit-PatchSet: 7
Gerrit-Owner: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sat, 29 Mar 2025 22:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dmitry Zhadinets
dzhadinets@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org