Change in flashrom[staging]: ichspi: Add support for Intel Skylake

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/18962 )

Change subject: ichspi: Add support for Intel Skylake
......................................................................

Patch Set 4:

(1 comment)

ichspi.c has too much code and too many unknown concepts for me to review at this time. Maybe I'll do that later when I get more familiar with it all...

https://review.coreboot.org/#/c/18962/4/ich_descriptors.c
File ich_descriptors.c:

Line 920: 	for (i = 0; i <= nr; i++)
Here, nr could be == 5 (above check is for nr > 5, not nr >= 5), and the loop now does i<=nr, so 'i' might be == 5 in the loop, but desc->region.FLREGs has a size of 5, so you'll get an out of bounds write.