Attention is currently required from: Nikolai Artemiev, ra1nb0w.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69678?usp=email )
Change subject: flashchips: Add Macronix MX25R1635F ......................................................................
Patch Set 2: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69678/comment/61f8df32_1b14e9ba : PS1, Line 13: Tested
Can you mention which operation you tested, did you run verify at the end? […]
Done
Patchset:
PS1:
Davide, I am so sorry that your patch got missed :\ I hope you are still here! Do you have a link to […]
Done
Patchset:
PS2: Thank you for your contribution!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/69678/comment/da52685e_4300739e : PS1, Line 9306: .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit 6 is quad enable */ : .unlock = spi_disable_blockprotect_bp3_srwd,
These two are now enums are well (not function pointers anymore). […]
Done
-
Anastasia Klimchuk (Code Review)