Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66531 )
Change subject: cli_classic: wrap options validation in function
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
I've provided a list of commands that I used to test this patch. […]
Looks great, thank you so much!
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/66531/comment/3abe74eb_4fe0e4c3
PS6, Line 827: if (options->logfile[0] == '\0') {
: cli_classic_abort_usage("No log filename specified.\n");
Please tell me what I am missing: where is this check now? I don't see it in `validate_options` ?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5685eb5ee3810ef2efd40a3901340e2ceb229ff
Gerrit-Change-Number: 66531
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Mon, 15 May 2023 11:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment