Change in flashrom[staging]: fixup of "Kill doit()" - flashrom-gerrit

17 Jun 2017


      Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()"
......................................................................
Patch Set 1:
(re: the message, yeah you could but that wasnt the obvious workflow, actually I was very confused...)
Re: the guards, then you'd need to build internal.o always (since Makefile doesnt build it if no CONFIG_INTERNAL), and include an useless piece of .bss in the binary. You dislike guards that much?
-- 
To view, visit https://review.coreboot.org/20250
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko urjaman@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Urja Rannikko urjaman@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Jun 2017 10:50:53 +0000
Gerrit-HasComments: No