[S] Change in flashrom[master]: [WIP] test_build.sh: Rework programmer selection using Meson
Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68068 )
Change subject: [WIP] test_build.sh: Rework programmer selection using Meson ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Maybe we should just go with the programmer list in test_build.sh. […]
Is that file not in a standard format? I wouldn't know, is it python?
A completely different thought occured to me: Maybe the problem is that we are trying to write a build system on top of build systems. We already have these lists in a programmable context (make and meson each). The repeated builds are easy enough to write in make, how is it in meson? If it's not possible, maybe that's something we should teach it?
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/68068/comment/63b04e26_daff42cc PS2, Line 52: programmer_list=$(cat ${meson_logfile} | tail -n 1 | sed 's/^.*auto/auto/' | sed 's/,//g' | sed 's/"//g')
If anybody knows a better way how to get a list of available programmers, I am open for suggestions
Is there no way to show the available option arguments (on stdout)? How do human users do it?
-
Nico Huber (Code Review)