Attention is currently required from: Thomas Heijligen, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74157 )
Change subject: tests: Emulate multithreading environment for unit tests
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS2:
Yes, I'd prefer to always create a thread and get rid of the `__isthreaded` poke for other BSDs. […]
Finally, it seems like we got to the other side of rabbit hole! :) I tested the version without pre-processor conditionals, it works!
One more patch is needed though, I pushed it as a previous one for the chain CB:74202 but otherwise looks like that's it?
Peter thank you so much, your help is invaluable!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d65c125183e60037ad07b9d54b8fffdece5a4e8
Gerrit-Change-Number: 74157
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 04 Apr 2023 13:17:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment