Nico Huber has posted comments on this change. ( https://review.coreboot.org/26947 )
Change subject: bitbang_spi: Add half-duplex optimizations ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/26947/2/bitbang_spi.c File bitbang_spi.c:
https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@128 PS2, Line 128: if (i == 0) : bitbang_spi_set_sck_set_mosi(master, 0, 0); : else : bitbang_spi_set_sck(master, 0);
SPI is an ad-hoc standard; very little is defined anywhere! […]
I wasn't paying attention obviously. It's not about SPI but whatever the flash chip expects after the command. I can see from random data- sheets that they don't care. But that's no proof that there is no chip that does care so let's keep it.