Change in flashrom[staging]: chipset_enable: Add support for Intel Skylake - flashrom-gerrit

25 Apr 2017


      Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/18925 )
Change subject: chipset_enable: Add support for Intel Skylake
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/18925/2/chipset_enable.c
File chipset_enable.c:
PS2, Line 869: spi_dev
...
Not sure what the contract is here. Are we allowed to free(spi_dev) right
We do anyways, despite the if constructs below.
Line 870: 	if (ret_spi == ERROR_FATAL)
Do we really need a goto here?
if (ret_spi != ERROR_FATAL) 
  if (ret_bc || ret_spi)
    ret = ERROR_NONFATAL;
  else
    ret = 0;
?
-- 
To view, visit https://review.coreboot.org/18925
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I000819aff25fbe9764f33df85f040093b82cd948
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes