[M] Change in flashrom[main]: erase_func_algo: Avoid putting 0xff into buffers - flashrom-gerrit

23 Nov 2023


      Attention is currently required from: Anastasia Klimchuk.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79229?usp=email )
Change subject: erase_func_algo: Avoid putting 0xff into buffers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
In theory, there could be more than one way to erase. […]
Thanks for the detailed explaination!
Yes, I found this behaviour inconsistant while porting this to chromium flashrom. I would be grateful if there's any related performance materials that could share with me.
I'll abandon this change.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/79229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ibe159f9f7cf35688cfdbe18245fea2d870386412
Gerrit-Change-Number: 79229
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 23 Nov 2023 10:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen roccochen@google.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment