Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom) ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/23203/10/cli_classic.c File cli_classic.c:
https://review.coreboot.org/#/c/23203/10/cli_classic.c@254 PS10, Line 254: fprintf(stderr, "Error: --fmap and --ifd both specified. Aborting.\n")
If you want to have these two optione really exclusive you shuld check in the case OPTION_IFD if fma […]
Layouts shouldn't be exclusive IMO, but we should handle it gracefully (checking conflicts for instance).
https://review.coreboot.org/#/c/23203/10/flashrom.8.tmpl File flashrom.8.tmpl:
https://review.coreboot.org/#/c/23203/10/flashrom.8.tmpl@204 PS10, Line 204:
Maybe add "on" here?
ok