Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59741 )
Change subject: tests: Add run_probe_lifecycle and add dummyflasher probe test
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59741/comment/62594a82_b5484306
PS4, Line 28: = NULL
No need to initialize *flashctx. This is done by flashrom_flash_probe.
https://review.coreboot.org/c/flashrom/+/59741/comment/963ea1e5_a06432fc
PS4, Line 45: = NULL
No need to initialize *flashprog. This is done by flashrom_programmer_init.
Until then we don't know the value of *flashprog and should not assume it's NULL.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36
Gerrit-Change-Number: 59741
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 08:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment