Change in flashrom[master]: pony_spi.c: Extract out get_params to simplify init
Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Light. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63130 ) Change subject: pony_spi.c: Extract out get_params to simplify init ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63130/comment/cf0f5029_97fd7e36 PS5, Line 9: function pony_init_spi)`,
I would appreciate if you move this to the next line. […] Done
https://review.coreboot.org/c/flashrom/+/63130/comment/6be39e72_c863ea25 PS5, Line 10: number of
same here Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/63130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I364febc05c870683cbad114583762b0c006f4bac Gerrit-Change-Number: 63130 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Light <aarya.chaumal@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Felix Singer <felixsinger@posteo.net> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Light <aarya.chaumal@gmail.com> Gerrit-Comment-Date: Sat, 30 Apr 2022 00:42:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment
participants (1)
-
Edward O'Callaghan (Code Review)