Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72502 )
Change subject: jedec.c: Consolidate op,operand sequencing into func
......................................................................
Patch Set 5:
(1 comment)
File jedec.c:
https://review.coreboot.org/c/flashrom/+/72502/comment/24bcf3ac_16db0e8b
PS4, Line 325: toggle_ready_jedec_slow(flash, bios);
It seems that toggle_jedec_slow could dereference flash->virtual_memory itself here.
done here https://review.coreboot.org/c/flashrom/+/72691/1
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a1b211b49777f6d7f62a052975c1759e036c8df
Gerrit-Change-Number: 72502
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Feb 2023 01:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment