Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 )
Change subject: Introduce an `include` directory for header files
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS7:
I downloaded this patch on the top of the tree locally, it got applied automatically, no conflict resolutions were needed. I also checked that flash.h in latest patchset is up-to-date (contains SR3 support).
You can also use Gerrit's Rebase feature. What you did is exactly what
"Rebase on top of the master branch (breaks relation chain)" does. If
that fails, nothing happens, if it works, you know the patch applied
cleanly (and you, and other, can still verify things in Gerrit).
No need to do so, I guess I got used to it because it saves me one
switch to the command line and back when I "only wanted to merge
something".
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 29 Apr 2022 10:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment