Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
......................................................................
Patch Set 2:
(1 comment)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/c2501d7e_655b3151
PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
First, thanks for taking the time to write such a detailed explanation of how the dev cycle works. […]
1. git checkout <my_branch>
2. git fetch upstream master (get the latest version of upstream)
3. git rebase (this puts my commit over the current head)
4. Edited the file in question
5. trying to amend the commit...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f
Gerrit-Change-Number: 66225
Gerrit-PatchSet: 2
Gerrit-Owner: Shreeyash
shreeyash335@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 21 Oct 2022 16:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Shreeyash
shreeyash335@gmail.com
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment