Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/71285 )
Change subject: tests: Fix warnings for 32-bit Linux ......................................................................
tests: Fix warnings for 32-bit Linux
Unit tests had int-to-pointer-cast warnings for 32-bit Linux environment, and since warnings are treated as errors this failed build with unit tests.
Ticket: https://ticket.coreboot.org/issues/407
Original-Tested-By: Branden Waldner scruffy99@gmail.com Original-Signed-off-by: Anastasia Klimchuk aklm@chromium.org Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/72038 Original-Tested-by: build bot (Jenkins) no-reply@coreboot.org Original-Reviewed-by: Angel Pons th3fanbus@gmail.com Original-Reviewed-by: Alexander Goncharov chat@joursoir.net (cherry picked from commit 87531ef11c00963100f20fac71c2428f54162916)
Change-Id: I9ec5d37cc038171afc67a69ea9a6885deb8fa4a8 Signed-off-by: Evan Benn evanbenn@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/71285 Reviewed-by: Anastasia Klimchuk aklm@chromium.org Tested-by: Anastasia Klimchuk aklm@chromium.org --- M tests/linux_spi.c 1 file changed, 29 insertions(+), 2 deletions(-)
Approvals: Anastasia Klimchuk: Verified; Looks good to me, approved
diff --git a/tests/linux_spi.c b/tests/linux_spi.c index 2e3dc95..d71e5b4 100644 --- a/tests/linux_spi.c +++ b/tests/linux_spi.c @@ -23,14 +23,14 @@
/* First message has write array and write count */ unsigned int writecnt = msg[0].len; - unsigned char *writearr = (unsigned char *)msg[0].tx_buf; + unsigned char *writearr = (unsigned char *)(uintptr_t)msg[0].tx_buf; /* Second message has read array and read count */ unsigned int readcnt = msg[1].len;
/* Detect probing */ if (writecnt == 1 && writearr[0] == JEDEC_RDID && readcnt == 3) { /* We need to populate read array. */ - unsigned char *readarr = (unsigned char *)msg[1].rx_buf; + unsigned char *readarr = (unsigned char *)(uintptr_t)msg[1].rx_buf; readarr[0] = 0xEF; /* WINBOND_NEX_ID */ readarr[1] = 0x40; /* WINBOND_NEX_W25Q128_V left byte */ readarr[2] = 0x18; /* WINBOND_NEX_W25Q128_V right byte */