Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()" ......................................................................
Patch Set 1:
Oh, the handling of that flag seems all kinds of weird to me, in general.
I could go with not having it in the flashctx, which would make it an internal programmer parameter that flashrom_image_write happens to look at (but there's guards there for it anyways already). (Having it only in flashctx comes with the issue that the flashctx doesnt exist when initializing the programmer...) Or it could be split into two parameters, but ... ehh, i'm not even sure if having the flashctx part makes sense without internal, etc.
This is very confusing to me and I'm here to fix the build, not fix the architechture :P