Attention is currently required from: Nicholas Chin, ZhiYuanNJ.
Anastasia Klimchuk has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email )
Change subject: ch347_spi: Add spi clock frequency selection ......................................................................
Patch Set 10:
(1 comment)
File ch347_spi.c:
https://review.coreboot.org/c/flashrom/+/82776/comment/e772d905_4fb239e4?usp... : PS7, Line 365: 30MHz
Sorry for the late reply. […]
I have a suggestion, but please tell me what you all think about it.
This thread is about changing/ or not changing default value, but no one argues about the feature itself. Maybe you can have first patch which adds the feature but keeps the default as is? And then later, in a separate patch, you can change the default value (if you both agree this is a good idea to change it). Or maybe you will keep the default.
My point is that we can go ahead with the feature, and then spend more time discussing just the question of what is the best default setting.
What do you think?
-
Anastasia Klimchuk (Code Review)