[M] Change in flashrom[master]: Revert "flashrom.c: Remove programmer_param global state" - flashrom-gerrit

14 Sep 2022


      Attention is currently required from: Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67621 )
Change subject: Revert "flashrom.c: Remove programmer_param global state"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Oh I didn't know it's a valid use case to invoke initialisation with NULL prog params :\ But now I k […]
Thanks for spotting this corner case and the revert Thomas! Yes great idea to get this covered by the test too! Feel free to merge right away!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b689ad4bdd0c9c3b11f30becafc878c78630f0b
Gerrit-Change-Number: 67621
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Wed, 14 Sep 2022 00:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment