[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to bus master
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to bus master ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2:
Moving the map/unmap functions out of the programmer_entry struct is a good thing. […]
Yeah I think that would also work. I agree I don't think any of the SPI/opaque masters actually need this. I mainly kept it around to keep this change a strict refactor (thought it would be easier to review with the actual change in behavior called out separately) and because I couldn't test the others.
I tried the ICH9 swseq briefly but just got timeouts on the boards I tested (with no changes); didn't have time to dig into it yet. The only hardware programmers I have are ch341a_spi and ft2232_spi.
File atapromise.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/71eb665a_ede41570 PS2, Line 133: atapromise_map
This may not be needed any longer, because `atapromise_map` has the same implementation as `fallback […]
Agree, will tweak this when I'm back Tuesday.
File atavia.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/1253a66d_3c0e339f PS2, Line 147: atavia_map
This may also not be needed, CB:67656 […]
If you can test that would be awesome, FWIW I could keep this around even if we move the mapper into par_master though.
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/a0c95d76_3784822b PS2, Line 582: .map_flash_region = serprog_map, Does anyone know if this is needed?
I'm pretty sure ICH7/9 swseq don't need mappers, but if this one does, and we want to move the mapper into the bus master structs, then I will add a mapper to spi_master too.
-
Jonathon Hall (Code Review)