Change in flashrom[master]: nicintel_eeprom.c: Mark 8086:1531 as tested
Attention is currently required from: Angel Pons, Arthur Heymans, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52825 ) Change subject: nicintel_eeprom.c: Mark 8086:1531 as tested ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52825/comment/05a5c5f1_afbbf165 PS1, Line 9: Reading, erasing and writing works on an i210 NIC of an Asus Z10PA-D8.
Is it important to have TEST=something something line in commit message? I noticed that some commits […] The BUG+BRANCH+TEST lines is a Chromium requirement, upstream does not generally care for it so this is optional for them.
-- To view, visit https://review.coreboot.org/c/flashrom/+/52825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cabea5dfb9424b9c30d82840089506f2bd943da Gerrit-Change-Number: 52825 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Sun, 02 May 2021 23:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Edward O'Callaghan (Code Review)