Change in flashrom[master]: writeprotect.c: refactor and fix wp_mode functions - flashrom-gerrit

4 Apr 2022


      Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62643 )
Change subject: writeprotect.c: refactor and fix wp_mode functions
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62643/comment/8c819490_3a17d4f8 
PS10, Line 12: since a chip without SRP is just FLASHROM_WP_MODE_DISABLED
Just to double-check, chip without SRP/SRL will have
bits->srp = 0 and bits->srl = 0 without errors, right?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib6c347453f9216e5816e4ed35bf9783fd3c720e0
Gerrit-Change-Number: 62643
Gerrit-PatchSet: 10
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 02:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment