Attention is currently required from: Nico Huber, Stefan Reinauer, Angel Pons, Arthur Heymans. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 )
Change subject: hwaccess.c: Fix PowerPC memory barrier ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52470/comment/0a7a1c48_15ce5019 PS1, Line 10: rotten link.
My best guess: CB:47908
That seems extremely likely Angel, good spot! It is very unfortunate the toolchain defaults of a given release are being leaned on leaning to a build up of brokeness being papered over.
Nico, do you happen to have a SPARC box or similar to ssh into for investigation? I suspect we have sadly accrued an eclectic series of pitfalls over time due to the missing toolchain constraints. It would surely nice to see these fixed.
Stefan, is it somehow possible to get a SPARC box off ebay and include it as a buildbot? I don't know how that side of the infra works? Google is certainly a hard environment to work outside the confines of the world being entirely x86+ARM just because of the realities no matter how well intended the developer is.
-
Edward O'Callaghan (Code Review)