Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70027 )
Change subject: libflashrom: Define macro to detect v1.3 header
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I talked to aklm about unblocking the release. […]
I'm not against doing it this way, but I'm wondering how this gets used. Do we keep this macro forever? or drop it at v1.4 and add a v1.4 macro?
It seems like I as a library user might want to know something like; version is at least 1.4, or version is between 1.5 and 1.6. That sounds complicated with a symbolic macro like this.
`__STDC_VERSION__` is a case study, it is defined to a number (date), so I can test
`#if __STDC_VERSION__ > 202201`
Maybe we could do `#define LIBFLASHROM_VERSION` $MAJOR$MINOR?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac35ff167272e1bc3d5434f7b47099f53bfceab7
Gerrit-Change-Number: 70027
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 28 Nov 2022 22:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment