[XS] Change in flashrom[main]: flashrom: Don't throw around "delay 1 second" so lightly

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Brian Norris, Nikolai Artemiev, Peter Marheine.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )

Change subject: flashrom: Don't throw around "delay 1 second" so lightly
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS1:
> If nobody knows why this is necessary or how to reproduce, I think it's okay to remove.

Yes, true.
I was trying to find out which exactly chips needed that extra delay, but no success so far. If we knew which chips we could add a feature flag as Nikolai suggested, and mark them in flashchips. But it seems, we don't know.

So your plan looks very reasonable: an option will cover for the edge cases (if they exist).

I was thinking to start from a post on a mailing list, very specifically about removing 1s delay (there has been none dedicated thread), so that if someone suddenly recalls information about those odd chips, they can share. Even if no one responds, it stays in archives as a record of decision being made with explanation why.
And then update this patch with an option, post link to patch to the thread. That should be enough for the "paperwork" :)