Attention is currently required from: Brian Norris, Nikolai Artemiev.
Hello Brian Norris, Edward O'Callaghan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/75991?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Brian Norris, Verified+1 by build bot (Jenkins)
Change subject: flashrom: only perform WP unlock for write/erase operations ......................................................................
flashrom: only perform WP unlock for write/erase operations
Don't unlock using WP for read/verify operations because WP will only disable write locks. Most chips don't have read locks anyway, but some do, so we still call the chip's unlock function for read/verify operations.
Unconditionally unlocking using WP slows down flashrom significantly with some programmers, particularly linux_mtd due to inefficiency in the current kernel MTD interface.
BUG=b:283779258 BRANCH=none TEST=`ninja test` TEST=`flashrom -{r,w,E,v}` on strongbad TEST=`flashrom --wp-enable; flashrom -{w,E}` on strongbad
Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1 Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M flashrom.c 1 file changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/75991/2