Attention is currently required from: Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 )
Change subject: linux_mtd: Switch fopen() to open() for MTD devices
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/50206/comment/a4a43916_8361f83e
PS2, Line 26: overhead / translation that we just don't need.
Proof?
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/50206/comment/f59485ad_1a049631
PS2, Line 206: if (read(dev_fileno, buf + i, step) != step) {
AFAIR, read() can be interrupted and return a short count even if
everything is alright. Is that not true for MTD device files?
If it can't be interrupted, is that specified somewhere or
implementation specific?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/50206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d
Gerrit-Change-Number: 50206
Gerrit-PatchSet: 2
Gerrit-Owner: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Douglas Anderson
dianders@chromium.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 15 Mar 2021 15:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment