[M] Change in flashrom[master]: flashrom_tester: Add positive check to verify_fail_test - flashrom-gerrit

13 Feb 2023


      Attention is currently required from: Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71974 )
Change subject: flashrom_tester: Add positive check to verify_fail_test
......................................................................
Patch Set 10:
(1 comment)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/71974/comment/57c43d70_996dd5c8 
PS10, Line 274:  Some
this doesn't type check.
https://review.coreboot.org/c/flashrom/+/72674
I think the forward fix is to drop the `Some()` constructor but perhaps this patch wasn't tested somehow?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71974
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibbcc97086466b67cfab4f6c32140bb5f2c456beb
Gerrit-Change-Number: 71974
Gerrit-PatchSet: 10
Gerrit-Owner: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Evan Benn evanbenn@google.com
Gerrit-Comment-Date: Mon, 13 Feb 2023 05:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment