Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62554 )
Change subject: layout: Change signature for prepare_layout_for_extraction ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Thanks for reply! :)
I'm not sure if I mentioned this somewhere already, the topic seems familiar. I kind of see this extract feature as CLI code.
Sorry if I missed that! I don't remember, but maybe because extract feature was upstreamed earlier when I just started and I wasn't fully aware of all everything that going on. My reasoning for this patch chain was to align with larger movement to make cli a libflashrom user, which means libflashrom is used from everywhere and needs to be tested.
So far, we have kept libflashrom free from file i/o and some target environments just don't support it
Maybe I am missing something, but I don't see `prepare_layout_for_extraction` doing file i/o at the moment? It is populating file names, which is prep step for i/o, but the i/o itself is done next in read operation. Maybe `prepare_layout_for_extraction` can be renamed into something more specific? I agree with keeping libflashrom free from file i/o.
-
Anastasia Klimchuk (Code Review)