Attention is currently required from: Felix Singer, Idwer Vollering, Angel Pons, Light.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 )
Change subject: board_enable.c: Remove unnecessary assignment
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Patchset:
PS10:
Not sure whether Keith you have seen it, or maybe you don't care about Tested-by tag? […]
I saw it but missed replying. My bad.
It's true though I seem to be the only one to have build tested and reported back. Fine by me either way, and go ahead and merge.
ps. flashrom is userspace, and I/O port reads actually call into the kernel. There's plenty delay right there per read. Not so-and-so microseconds accurate, but enough for our use case.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 10
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 02:08:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment