Attention is currently required from: Nico Huber.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52595 )
Change subject: mec1308.c: Extract params check into a function
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52595/comment/6dab620b_25717b98
PS1, Line 9: This allows char *p to become a local variable in
It's literally a limit, though. There is no recommendation or […]
I can explain why I thought it's a good idea to make it wider: so that commit message spans less lines (so it takes more width less height), and git log fits more commits into a screen. I view git log very often, and it's nice when I don't need to scroll :)
What do you think about it?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52595
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If5be7709e93233a2e7ea9133de50382d2524a55f
Gerrit-Change-Number: 52595
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-CC: Victor Ding
victording@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 26 Apr 2021 01:32:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment