Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57808 )
Change subject: ft2232_spi: clarify the comment about gpio configuration
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57808/comment/05369707_1cbe8507
PS2, Line 94: GPIOL* pins are
: * configured as inputs
mentioned them as well now; recheck, please
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaceec889a65ead8cdde917f61b2a9695d440f781
Gerrit-Change-Number: 57808
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 23 Sep 2021 08:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment