Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )
Change subject: dummyflasher.c: Extract params processing into a separate function ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: I'm sorry that you'll have to manually rebase this change, but I *really* had to make CB:54905 CB:54908 CB:54909 CB:54910 to blow off some steam after noticing these issues.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/1d5e1d11_ac41efe2 PS2, Line 971: free(status); : if (errno != 0 || status == endptr) {
For another patch: this has an use-after-free bug, just like the one CB:46551 fixed.
CB:54909 takes care of it.
https://review.coreboot.org/c/flashrom/+/54748/comment/a55b7321_2bda9960 PS2, Line 1014:
I would initialise `data->flashchip_contents` here: […]
I moved around the initialisation in CB:54908