Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77438?usp=email )
Change subject: doc: Add html_logo and html_title to sphinx config
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
What's the point of displaying logo on every page? It's not a commercial logo, we're not selling any […]
I guess I was trying to do the same as wiki (re displaying logo on every page). But maybe it's not necessary.
You are right about alignment, it hurts eyes a little bit. From a quick look, I didn't find the easy way to change alignment (apart from providing custom css files, which I don't want to do).
Maybe I will leave this patch hanging for some time, I will read documentation again to see what are all available config options to display logo.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77438?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a530f7143880393fffc2a97327416f2cd688586
Gerrit-Change-Number: 77438
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Fri, 08 Sep 2023 08:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment