Attention is currently required from: Matt DeVillier.
Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email )
Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/85159/comment/a2f9b937_20c1c230?usp... : PS2, Line 21: TEST=verify read/write/verify operations successful when specifying : the filename only after the region.
As a note, you can just copy-paste the list of commands that you ran to test, might be easier than w […]
Done
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/85159/comment/c83f9af9_e77d9932?usp... : PS3, Line 1344:
There are few trailing spaces (shown in gerrit in bright pink) in this comment
Done
https://review.coreboot.org/c/flashrom/+/85159/comment/ef366126_ccdb04af?usp... : PS3, Line 1366: * - If file is specified for -w/-v and no files are specified with -i : * args, then the file is to be used for writing/verifying the entire : * ROM.
Maybe this one can be promoted to common rules? It does apply to all of them -r/-w/-v ?
Done