Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64540 )
Change subject: ichspi.c: Implement read_write_status for wp ......................................................................
Patch Set 2:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/64540/comment/e7f81b2d_550acf74 PS1, Line 122: FIXME(quasisec): Port to new macros? - Control bits
@Subrata, what did you suggest downstream to clean this up here?
I don't think you need any of these new macro here.
line #138 onwards should care of of everything.
You just need two new macro as in below:
#define HSFC_CYCLE_WR_STATUS HSFC_FCYCLE(7) #define HSFC_CYCLE_RD_STATUS HSFC_FCYCLE(8)
and update the read/write status as https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+...
-
Subrata Banik (Code Review)