Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68296 )
Change subject: flashrom.c: Separate out default layout init ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68296/comment/9da24112_8e2eb4e0 PS1, Line 7: Seperate
Yes I have dyslexia so that would be great! Also fast review O_o thanks
Oh, we didn't know that you have dyslexia! Apologies if we ever made you feel bad about it; we'll try to get automated spell-checking soon™.
About fast review: we enabled *something* and we now receive emails for any new flashrom changes, so we just saw this. In fact, we were so quick that we started reviewing CB:68297 before it was marked as WIP, hence the slight confusion... 😅
[Hmmm, why didn't Edward mark this comment as resolved? Oh wait, because it's not fully resolved...] We just created https://ticket.coreboot.org/issues/419 to not forget about the automatic spell-checking. 😊
-
Angel Pons (Code Review)