Change in flashrom[master]: ogp_spi.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

31 May 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54996 )
Change subject: ogp_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 3:
(1 comment)
File ogp_spi.c:
https://review.coreboot.org/c/flashrom/+/54996/comment/c32bfe18_d6d7a7ef 
PS2, Line 40: ogp_
...
similar to the others, this `ogp_` prefix can be dropped from the members.
Done. I saw that there are some prefixes still left after the first round of reviews, thought maybe it was intentional. I should have asked of course.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/54996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6b8f6ecd7c9949ffb4098bf56a8936393283382f
Gerrit-Change-Number: 54996
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 31 May 2021 23:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment