Change in flashrom[master]: linux_spi.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

15 Apr 2021


      Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52285 )
Change subject: linux_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File linux_spi.c:
https://review.coreboot.org/c/flashrom/+/52285/comment/579b65eb_46528cc8 
PS1, Line 74: spi_data->fd = -1;
no longer needed to set fd back to -1 as spi_data is freed after this branch.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93408c2ca846fca6a1c7eda7180862c51bd48078
Gerrit-Change-Number: 52285
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 15 Apr 2021 02:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment