Change in flashrom[master]: ft2232_spi: reintroduce generic GPIOL control

[Michael Niewöhner (Code Review)]

Attention is currently required from:  Felix Singer, Alan Green, Nico Huber, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )

Change subject: ft2232_spi: reintroduce generic GPIOL control
......................................................................

Patch Set 10:

(5 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/57810/comment/3fec54f1_3caaae77 
PS2, Line 22: 
            : TODOs:
            :  - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment)
            :  - reword commit message
            :  - man page for both `csgpiol`, `gpiol`
            :
> Thank you for being thorough about this!

Done

Commit Message:

https://review.coreboot.org/c/flashrom/+/57810/comment/b8c350d1_5f06f271 
PS4, Line 20: In the event that
            : both arguments are specified, gpiol is used.
> This paragraph is also the original commit message, right?

yes

Patchset:

PS6:
> Ack, let's go for the gpiolX=y variant

Done

File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/57810/comment/dabb1381_2029c10e 
PS2, Line 530: 					/* * * * * * * * * * * * * * * * * * * * * * * * * * *
             : 					 * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` *
             : 					 * * * * * * * * * * * * * * * * * * * * * * * * * * */
             : 					case 'C':
             : 						cs_bits  |= 1 << gpiol_pin;
             : 						pindir   |= 1 << gpiol_pin;
             : 						break;
             :
> Sounds good. It would also allow us to make the two interfaces mutually […]

Done

File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/57810/comment/df3bb258_5209b4e8 
PS4, Line 90:  * The variables `cs_bits` and `pindir` store the values for the
            :  * "set data bits low byte" MPSSE command that sets the initial
            :  * state and the direction of the I/O pins. `cs_bits` pins default
            :  * to high and will be toggled during SPI transactions. All other
            :  * output pins will be kept low all the time. GPIOL* pins are
            :  * configured as inputs, while it's possible to use one of them as
            :  * additional CS# signal through the parameter `csgpiol`. On exit,
            :  * all pins will be reconfigured as inputs
> Reminder: this comment will need updating.

Done