Attention is currently required from: Douglas Anderson, Angel Pons, Patrick Rudolph.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 )
Change subject: linux_mtd: Switch fopen() to open() for MTD devices
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
How should we proceed here? I don't have a great environment for testing pure upstream flashrom but […]
Sorry for the delay and thanks for driving changes in upstream first. This does seems fine to me, however, I guess the commit message needs a bit more convincing elaboration for anyone not familiar with the complete context here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/50206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d
Gerrit-Change-Number: 50206
Gerrit-PatchSet: 1
Gerrit-Owner: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Douglas Anderson
dianders@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Mar 2021 00:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Douglas Anderson
dianders@chromium.org
Gerrit-MessageType: comment