Julian von Mendel has posted comments on this change. ( https://review.coreboot.org/25047 )
Change subject: Support for Atmel / Adesto AT25SF041 SPI flash chip ......................................................................
Patch Set 3: Code-Review+1
I did function tests with read/write/erase, no systematic flash performance tests or similar.
I had a Pi connected to the SPI flash chip, that contained FPGA configuration data (that were already on the chip). I read the data, erased, read that as well, confirmed that both images made sense in a hex editor and that the FPGA did no longer configure. I wrote back the original image and the FPGA worked as it did before. No errors during flashrom verify. (Possible flaw in that test: Only a small portion of the address space was filled with non-zero data.)
Sorry about the comments in the .c file, I am not sure about these (they were copied from AT26DF041).
-
Julian von Mendel (Code Review)