Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 )
Change subject: writeprotect: Add function to get register values and WP bit masks
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/69847/comment/159a48cb_1821a4ab
PS5, Line 363: strdup(
you do not need a heap allocation, just a `const char *`
https://review.coreboot.org/c/flashrom/+/69847/comment/06a61abb_7b8ff2fe
PS5, Line 396: free(param_dup);
drop
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20
Gerrit-Change-Number: 69847
Gerrit-PatchSet: 5
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 23 Jan 2023 07:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment