Attention is currently required from: Arthur Heymans, Nico Huber, David Hendricks, Angel Pons.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57581 )
Change subject: ich_descriptors: Add check for ISL == 139 for LBG
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think this patch alone is enough to fix Ibex Peak detection, because of the changed check (the `<= […]
Correct - Since this checks for the exact ISL values we expect for EBG/LBG it should work on those chipsets only. The "default" behavior, which assumes Ibex Peak compatibility, will not be impacted.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icb8d19fd6771ed787b488044aa5ed5516812b27c
Gerrit-Change-Number: 57581
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: David Hendricks
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 13 Sep 2021 17:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment