Change in flashrom[master]: hwaccess: fix build on non-x86 targets - flashrom-gerrit

23 Jan 2022


      Attention is currently required from: Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
Patchset:
PS1:
...
61276 in particular looks like a nice cleanup of these headers. […]
It doesn't change a thing about the problem at hand, though, that code compiled
for non-x86 includes an x86 file.
Patchset:
PS5: 
This is a step backwards, having an `if x86` in an x86 file can't be good.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 23 Jan 2022 23:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org
Gerrit-MessageType: comment